Skip to content

fix: eagerly initialise dependencies cache #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: eagerly initialise dependencies cache #47

merged 1 commit into from
Mar 22, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#19837

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

To avoid circular dependency errors, we can eagerly initialise the dependency cache. This means that any parent ids/dependencies we need to resolve can be resolved.

Note: This was only replicable with the nitro prerender build target, so I don't expect this to affect production vue rendering.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 21, 2023
@danielroe danielroe requested a review from pi0 March 21, 2023 08:15
@codecov-commenter
Copy link

Codecov Report

Merging #47 (dad8900) into main (fe3a42a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

πŸ“£ This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   95.25%   95.23%   -0.02%     
==========================================
  Files           6        6              
  Lines         527      525       -2     
  Branches      114      114              
==========================================
- Hits          502      500       -2     
  Misses         25       25              
Impacted Files Coverage Ξ”
src/runtime.ts 95.74% <100.00%> (-0.03%) ⬇️

πŸ“£ We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants