Potential fix for code scanning alert no. 2: Incomplete multi-character sanitization #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let previousHtml; | ||
| do { | ||
| previousHtml = html; | ||
| html = html.replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, ''); |
Check failure
Code scanning / CodeQL
Bad HTML filtering regexp High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
The best way to fix the problem is to use a well-tested HTML sanitization library instead of relying on a custom regular expression. This approach ensures that all edge cases and variations in HTML tags are properly handled, reducing the risk of security vulnerabilities.
To implement this fix, we will:
- Install the
sanitize-htmllibrary. - Replace the custom regular expression with a call to the
sanitize-htmllibrary to remove all<script>tags from the HTML.
Suggested changeset
2
src/runtime/server/og-image/templates/html.ts
| @@ -8,2 +8,3 @@ | ||
| import { applyEmojis } from '../satori/transforms/emojis' | ||
| import sanitizeHtml from 'sanitize-html' | ||
|
|
||
| @@ -116,7 +117,5 @@ | ||
| // need to remove ALL script tags from the html | ||
| let previousHtml; | ||
| do { | ||
| previousHtml = html; | ||
| html = html.replace(/<script\b[^<]*(?:(?!<\/script>)<[^<]*)*<\/script>/gi, ''); | ||
| } while (html !== previousHtml); | ||
| html = sanitizeHtml(html, { | ||
| allowedTags: sanitizeHtml.defaults.allowedTags.filter(tag => tag !== 'script'), | ||
| }); | ||
|
|
package.json
Outside changed files
| @@ -99,3 +99,4 @@ | ||
| "unwasm": "^0.3.9", | ||
| "yoga-wasm-web": "^0.3.3" | ||
| "yoga-wasm-web": "^0.3.3", | ||
| "sanitize-html": "^2.14.0" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| sanitize-html (npm) | 2.14.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/nuxt-modules/og-image/security/code-scanning/2
To fix the problem, we need to ensure that all instances of
<script>tags are removed from the HTML string, even if they are nested or malformed. The best way to achieve this is to apply the regular expression replacement repeatedly until no more replacements can be performed. This approach ensures that all script tags are effectively removed.We will modify the code on line 117 to repeatedly apply the regular expression replacement until the HTML string no longer changes. This will involve using a loop to check for changes in the HTML string after each replacement.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.