Skip to content

Update VSCode settings #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update VSCode settings #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fce25
Update translations
invalid-email-address May 21, 2025
6654f5a
updated settings.json
RyanMcCleary May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,9 +233,6 @@
"中文",
"日本語"
],
"flake8.args": [
"--max-line-length=130",
],
"git.ignoreLimitWarning": true,
"python.analysis.typeCheckingMode": "basic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the python.analysis settings duplicate pyright settings in pyproject.toml. can you confirm?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that seems to be the case. I think the only duplicated settings are the exclude directories, though. Do you agree?

"python.analysis.diagnosticMode": "workspace",
Expand All @@ -245,8 +242,18 @@
"python.analysis.diagnosticSeverityOverrides": {
"reportMissingImports": "none"
},
"triggerTaskOnSave.tasks": {
"flake8-whole-project": ["**/*.*py"]
},
"cmake.configureOnOpen": false
}
"python.languageServer": "Pylance",
"python.analysis.useLibraryCodeForTypes": true,

"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're encouraging a .venv it might be worth adding some notes in documentation somewhere such as the readme on setting up the .venv and pre-commit

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - I'll open another PR with additions to the readme.


"python.linting.enabled": true,
"python.linting.ruffEnabled": true,
"python.linting.ruffPath": "ruff",

"python.linting.pylintEnabled": false,
"python.linting.flake8Enabled": false,
"python.linting.mypyEnabled": false,

"cmake.configureOnOpen": false,
}