This repository was archived by the owner on Jul 7, 2022. It is now read-only.
rust-analyzer: Disable drawing hints for ParameterHint and TypeHint
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
line. We should only being drawing ChainingHint to avoid confusion until we have a proper solution for the other two.
|
does #19 work for you? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainingHintis the only type that makes sense to draw at the end of the line. This image demonstrates how each type should probably be represented.TypeHints after variable declarations,ParameterHints paired with variables passed into functions, andChainingHints at the end on lines. We'll need to slightly tweak the existing implementation to put these types in their correct place so for now I'm suggesting we only drawChainingHints to reduce confusion.