Skip to content

Package resource-pooling.0.1 #12396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jrochel
Copy link
Contributor

@jrochel jrochel commented Jul 25, 2018

resource-pooling.0.1

library for pooling resources like connections, threads, or similar

This package is derived from the module Lwt_pool from the lwt package,
which implements resource pooling. With Resource_pool this package
provides a modified version with additional features. Also there is a
module called Server_pool that manages resource clusters, specifically
a cluster of servers each with its own connection pool.



🐫 Pull-request generated by opam-publish v0.3.5

@camelus
Copy link
Contributor

camelus commented Jul 25, 2018

✅ All lint checks passed b40e184
  • These packages passed lint tests: resource-pooling.0.1

✅ Installability check (9184 → 9185)
  • new installable packages (1): resource-pooling.0.1

@kit-ty-kate
Copy link
Member

A constraint on lwt or something like that is probably required here

#=== ERROR while installing resource-pooling.0.1 ==============================#
# opam-version         1.2.2 (aa258ecc06d3aea5a67f442a4ffd23f2a457180b)
# os                   linux
# command              ocaml setup.ml -build
# path                 /home/opam/.opam/4.05.0/build/resource-pooling.0.1
# compiler             4.05.0
# exit-code            1
# env-file             /home/opam/.opam/4.05.0/build/resource-pooling.0.1/resource-pooling-7-97bbf8.env
# stdout-file          /home/opam/.opam/4.05.0/build/resource-pooling.0.1/resource-pooling-7-97bbf8.out
# stderr-file          /home/opam/.opam/4.05.0/build/resource-pooling.0.1/resource-pooling-7-97bbf8.err
### stdout ###
# [...]
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamldep -package lwt -package batteries -modules src/resource_pool.ml > src/resource_pool.ml.depends
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamldep -package lwt -package batteries -modules src/server_pool.mli > src/server_pool.mli.depends
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package lwt -package batteries -I src -o src/server_pool.cmi src/server_pool.mli
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamldep -package lwt -package batteries -modules src/server_pool.ml > src/server_pool.ml.depends
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package lwt -package batteries -I src -o src/resource_pool.cmo src/resource_pool.ml
# /home/opam/.opam/4.05.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package lwt -package batteries -I src -o src/server_pool.cmo src/server_pool.ml
# + /home/opam/.opam/4.05.0/bin/ocamlfind ocamlc -c -g -annot -bin-annot -package lwt -package batteries -I src -o src/server_pool.cmo src/server_pool.ml
# File "src/server_pool.ml", line 17, characters 14-34:
# Error: Unbound module Lwt_log
# Command exited with code 2.
### stderr ###
# E: Failure("Command ''/home/opam/.opam/4.05.0/bin/ocamlbuild' src/resource-pooling.cma src/resource-pooling.cmxa src/resource-pooling.a src/resource-pooling.cmxs -use-ocamlfind -tag debug' terminated with error code 10")

@mseri
Copy link
Member

mseri commented Jul 25, 2018

Wasn’t Lwt_log deprecated in favour of Log?

@jrochel
Copy link
Contributor Author

jrochel commented Jul 26, 2018

Indeed. The package is gone from lwt.4.*. I wasn't aware of that as I using an old version of lwt. I will soon update my library to use Logs_lwt from the logs package.

@jrochel jrochel force-pushed the opam-publish-resource-pooling.0.1 branch from 0b0ccc7 to d290a12 Compare August 1, 2018 11:41
@jrochel
Copy link
Contributor Author

jrochel commented Aug 1, 2018

For now I'll go with lwt 3. Once we port the application for which this package was developed to lwt 4 I will also port this package to use lwt 4 and the package logs.

@mseri
Copy link
Member

mseri commented Aug 1, 2018

In the ocaml-4.01 to ocaml-4.04 tests, for some reasons it tries to use lwt-2.4.5 and fails miserably. I think a lower bound forcing at least lwt-2.7 may be enough

@kit-ty-kate
Copy link
Member

This package needs at least lwt >= 2.4.7 and OCaml >= 4.02

@jrochel jrochel force-pushed the opam-publish-resource-pooling.0.1 branch from d290a12 to b40e184 Compare August 1, 2018 17:06
@jrochel
Copy link
Contributor Author

jrochel commented Aug 1, 2018

Thanks for the feedback. Sorry for the bother. I feel like I should have been more meticulous in my attempts create this package. Then again, it is my first one...

@kit-ty-kate
Copy link
Member

No worries. Also, for the record OASIS is not meant to be used like this. The OASIS files should be generated before doing the release using oasis setup which generates a lot of files and doesn't require any other dependencies than ocamlfind and ocamlbuild.
Also people tend to use dune or topkg nowadays but it's a matter of choice I guess.

Do you want to continue improving the package or should I merge it as is?

@jrochel
Copy link
Contributor Author

jrochel commented Aug 6, 2018

I'm fine with the package's current state. So I'd be grateful if you would merge it.

@kit-ty-kate kit-ty-kate merged commit ed163b6 into ocaml:master Aug 6, 2018
@kit-ty-kate
Copy link
Member

ok, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants