-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Package resource-pooling.0.1 #12396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package resource-pooling.0.1 #12396
Conversation
✅ All lint checks passed b40e184
✅ Installability check (9184 → 9185)
|
A constraint on
|
Wasn’t Lwt_log deprecated in favour of Log? |
Indeed. The package is gone from |
0b0ccc7
to
d290a12
Compare
For now I'll go with lwt 3. Once we port the application for which this package was developed to lwt 4 I will also port this package to use lwt 4 and the package logs. |
In the ocaml-4.01 to ocaml-4.04 tests, for some reasons it tries to use lwt-2.4.5 and fails miserably. I think a lower bound forcing at least lwt-2.7 may be enough |
This package needs at least lwt >= 2.4.7 and OCaml >= 4.02 |
d290a12
to
b40e184
Compare
Thanks for the feedback. Sorry for the bother. I feel like I should have been more meticulous in my attempts create this package. Then again, it is my first one... |
No worries. Also, for the record OASIS is not meant to be used like this. The OASIS files should be generated before doing the release using Do you want to continue improving the package or should I merge it as is? |
I'm fine with the package's current state. So I'd be grateful if you would merge it. |
ok, thx. |
resource-pooling.0.1
library for pooling resources like connections, threads, or similar
This package is derived from the module Lwt_pool from the lwt package,
which implements resource pooling. With Resource_pool this package
provides a modified version with additional features. Also there is a
module called Server_pool that manages resource clusters, specifically
a cluster of servers each with its own connection pool.
🐫 Pull-request generated by opam-publish v0.3.5