18.0 training gaso #771
Open
18.0 training gaso #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mathcoutant
reviewed
May 20, 2025
There was a problem hiding this comment.
Very good! Only small changes.
Also your commit titles don't follow the guidelines. They should have a specific title specifying the module concerned by the change. In this case it's always estate but it's a good habit you will have to learn.
And consider checking the style errors raised by the runbot to fix them.
added 20 commits
May 21, 2025 14:56
SouGab
force-pushed
the
18.0-Training-Gaso
branch
from
7b302bc to
df1af31
Compare
mathcoutant
reviewed
May 21, 2025
There was a problem hiding this comment.
Left some comments, some important, some less.
I didn't propose the correct diff, you have time to search for examples in odoo repo ;)
I noticed you sometimes changed the functional behavior the tutorial asks for, I'm ok with it, but I did some comments before realizing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.