Tutorials Amer #780
Tutorials Amer #780
Conversation
|
|
There was a problem hiding this comment.
Very good, just a small change to do.
Also your commit titles don't follow the guidelines. They should have a specific title specifying the module concerned by the change. In this case it's always estate but it's a good habit you will have to learn.
And consider checking the style errors raised by the runbot to fix them.
arthurrrm
force-pushed
the
18.0-training-amer
branch
from
769cc19 to
5821075
Compare
There was a problem hiding this comment.
Nice ! The tests are ok.
Functionally, with the current code, we can accept several offers for the same property, overriding each time buyer_id, selling-price, etc. We shouldn't be able to accept more than one offer.
Otherwise it's mainly small comments/improvements.
ruff.toml
Outdated
There was a problem hiding this comment.
Don't push this file on your PR, same for git files, vscode file
No description provided.