Skip to content

Update naming style to use snake_case instead of camelCase throughout the project #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 30, 2020
Merged

Update naming style to use snake_case instead of camelCase throughout the project #705

merged 7 commits into from
Jul 30, 2020

Conversation

machawk1
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is 19.96%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files          10       10           
  Lines        1248     1248           
  Branches      185      185           
=======================================
  Hits          365      365           
  Misses        860      860           
  Partials       23       23
Impacted Files Coverage Δ
ipwb/__main__.py 0.00% <0.00%> (ø)
ipwb/replay.py 14.06% <5.81%> (ø)
ipwb/util.py 43.56% <37.50%> (ø)
ipwb/indexer.py 50.19% <50.86%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9334ace...66d605b. Read the comment docs.

@machawk1 machawk1 marked this pull request as ready for review July 29, 2020 19:58
@machawk1 machawk1 requested a review from ibnesayeed July 29, 2020 19:58
ibnesayeed
ibnesayeed approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit 4e45b09 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibnesayeed ibnesayeed ibnesayeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machawk1 @ibnesayeed