This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Fix _create_keras_nodelist for test_rnn_state_passing #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnx#394) * Efficient-net test cases. * Add DepthwiseConv2d to subclassed model. * disable efficient net test cases.
wenbingl
approved these changes
Apr 6, 2020
|
@cjermain , previouslly, I forget where is the code to handle the sharing layer issue. now David has proposed the right way to fix it. |
|
Thanks @jiafatom for resolving that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in this PR breaks mask_rcnn nightly build, I reverted the relevant part then it breaks
test_rnn_state_passing, so I find the root cause in_create_keras_nodelistand fix it.