Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

improve the converter debugging #466

Merged
merged 6 commits into from
May 4, 2020
Merged

improve the converter debugging #466

merged 6 commits into from
May 4, 2020

Conversation

wenbingl
Copy link
Member

No description provided.

@wenbingl wenbingl requested a review from jiafatom April 30, 2020 19:16
jiafatom
jiafatom reviewed Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@jiafatom jiafatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the code _remove_unused_nodes, I am running nightly build to verify, but it seems running so long in tf2 case, will re-run to see if it impacts.

jiafatom
jiafatom reviewed May 1, 2020
View reviewed changes
Copy link
Collaborator

@jiafatom jiafatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR largely increases the nightly build time for tf2 case, for example, Linux from 12 minutes to 2.5 hours (the second time I am running already 40 minutes). Windows exceed 3 hours.
So it cannot check-in in current form.

jiafatom
jiafatom reviewed May 4, 2020
View reviewed changes
@jiafatom jiafatom merged commit 49e00fe into onnx:master May 4, 2020
@buddhapuneeth buddhapuneeth mentioned this pull request May 14, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jiafatom jiafatom jiafatom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenbingl @jiafatom