v3.0.x: Fix config/opal_setup_java.m4 from commit merged in #5119 #5161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That PR accidentally changed Open MPI's build configuration infrastruc- ture's Java toolchain detection logic so that it would, as reported by @bosilca in open-mpi#5001 (comment) and tracked down by me in open-mpi#5001 (comment), abort your entire in-progress Open MPI build when it failed to find an OS X/macOS JDK instead of simply falling back to checking for a JDK in locations where it would be found on other platforms. _Oops…!_ Signed-off-by: Bryce Glover <[email protected]> (cherry picked from commit 4a05c7e)
|
@bwbarrett @hppritcha This is a fix to a v3.0.x PR that was already merged (#5119). I checked: we did not include #5119 in the shipped v3.0.1, so we're ok -- both #5119 and this PR can be included in v3.0.2. @RandomDSdevel FYI. |
ggouaillardet
approved these changes
May 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR accidentally changed Open MPI's build configuration infrastructure's Java toolchain detection logic so that it would, as reported by @bosilca in #5001 (comment) and tracked down by me in #5001 (comment), abort your entire in-progress Open MPI build when it failed to find an OS X/macOS JDK instead of simply falling back to checking for a JDK in locations where it would be found on other platforms. Oops…!
Signed-off-by: Bryce Glover [email protected]
(cherry picked from commit 4a05c7e)
This is the v3.0.x version of the last java configury fix from #5160 (#5119 was already merged into v3.0.x branch, so I had to make a new PR for this one additional commit -- #5118 will include this PR when @ggouaillardet pulls it in).