Optimize removing negligible values #688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option that I'd prefer would be to add a single-argument overload of removeValue that doesn't have the pointer at all. Then you have more expressive call sites, we don't talk about |
BillyDonahue
reviewed
Oct 5, 2017
| @@ -534,6 +534,7 @@ Json::Value obj_value(Json::objectValue); // {} | |||
| /** \brief Remove the named map member. | |||
|
|
|||
| Update 'removed' iff removed. | |||
| 'removed' can be NULL if removed value is negligible. | |||
There was a problem hiding this comment.
The word "negligible" is almost misused here as it implies a small size. The removed value might be ignorable, but not because of its size. Ignorable would be a more plain choice. But see other comments as I think this optionally-null parameter isn't the best choice.
|
If @wolframroesler is right, can we close this PR? |
|
Alternate solution accepted in solution was accepted instead: #693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I don't care about removed value, so it will be easier just forget it (and not need to add local variable for it).