Skip to content

chore(user-interactions): remove component and user agent span attributes #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 16, 2023

Conversation

blumamir
Copy link
Member

Removed 2 attributes from user-interactions web instrumentation:

  1. component - this attribute is not speced, and the relevant data is already present in the scope name.
  2. http.user_agent - this attribute is recording navigator.userAgent which is static to the application and thus should be a resource attribute. The BrowserDetector already record this value into process.runtime.version, and it is thus duplicated on the span

@blumamir blumamir requested a review from a team January 30, 2023 17:06
@github-actions github-actions bot requested a review from obecny January 30, 2023 17:07
@blumamir
Copy link
Member Author

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #1366 (03a0215) into main (61255e2) will decrease coverage by 0.02%.
The diff coverage is 44.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   96.10%   96.08%   -0.02%     
==========================================
  Files          14       14              
  Lines         898      895       -3     
  Branches      192      192              
==========================================
- Hits          863      860       -3     
  Misses         35       35              
Impacted Files Coverage Δ
...ation-user-interaction/src/enums/AttributeNames.ts 100.00% <ø> (ø)
...umentation-user-interaction/src/instrumentation.ts 92.25% <44.44%> (-0.03%) ⬇️

@blumamir blumamir merged commit a9fa540 into open-telemetry:main Feb 16, 2023
Abinet18 pushed a commit to Abinet18/opentelemetry-js-contrib that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants