-
Notifications
You must be signed in to change notification settings - Fork 582
chore(user-interactions): remove component and user agent span attributes #1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
blumamir
merged 12 commits into
open-telemetry:main
from
blumamir:user-interactions-attributes
Feb 16, 2023
Merged
chore(user-interactions): remove component and user agent span attributes #1366
blumamir
merged 12 commits into
open-telemetry:main
from
blumamir:user-interactions-attributes
Feb 16, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.02%
==========================================
Files 14 14
Lines 898 895 -3
Branches 192 192
==========================================
- Hits 863 860 -3
Misses 35 35
|
haddasbronfman
approved these changes
Feb 15, 2023
Abinet18
pushed a commit
to Abinet18/opentelemetry-js-contrib
that referenced
this pull request
Feb 25, 2023
…utes (open-telemetry#1366) Co-authored-by: Haddas Bronfman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2 attributes from user-interactions web instrumentation:
component
- this attribute is not speced, and the relevant data is already present in the scope name.http.user_agent
- this attribute is recordingnavigator.userAgent
which is static to the application and thus should be a resource attribute. The BrowserDetector already record this value intoprocess.runtime.version
, and it is thus duplicated on the span