Skip to content

Provide advisory histogram boundaries when creating OpenAI metrics #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2025
Merged

Provide advisory histogram boundaries when creating OpenAI metrics #3225

merged 9 commits into from
Feb 10, 2025

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Feb 3, 2025 •
edited
Loading

Fixes #3235

Update:
I overhauled this PR and it now leverages advisory boundaries - no need for users to configure anything and most users should have good experience with default boundaries. So no OpenAI-specific example is necessary.

@lmolkova lmolkova requested a review from a team as a code owner February 3, 2025 03:08
@lmolkova lmolkova changed the title mall fixes in OpenAI examples Minor fixes in OpenAI examples Feb 3, 2025
@lmolkova lmolkova added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 3, 2025
@gyliu513
Copy link
Member

gyliu513 commented Feb 3, 2025

LGTM

codefromthecrypt
codefromthecrypt approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I guess this also applies to the auto-instrumentation, but also might water down how it looks, as we'd need to add code to the zero code ;)

thanks for linking to the issue

@lmolkova lmolkova changed the title Minor fixes in OpenAI examples Provide advisory histogram boundaries when creating OpenAI metrics Feb 7, 2025
codefromthecrypt
codefromthecrypt approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much

xrmx
xrmx approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xrmx xrmx enabled auto-merge (squash) February 10, 2025 09:32
@xrmx xrmx merged commit 231d26c into open-telemetry:main Feb 10, 2025
694 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@emdneto emdneto emdneto approved these changes

@alizenhom alizenhom Awaiting requested review from alizenhom

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@karthikscale3 karthikscale3 Awaiting requested review from karthikscale3

@lzchen lzchen Awaiting requested review from lzchen

@nirga nirga Awaiting requested review from nirga

@aabmass aabmass Awaiting requested review from aabmass

Assignees

@codefromthecrypt codefromthecrypt

@lmolkova lmolkova

@nirga nirga

@gyliu513 gyliu513

@lzchen lzchen

@karthikscale3 karthikscale3

@alizenhom alizenhom

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAI instrumentation: set explicit histogram boundaries when creating metrics
10 participants
@lmolkova @gyliu513 @xrmx @codefromthecrypt @aabmass @emdneto @nirga @lzchen @karthikscale3 @alizenhom