Skip to content

Add _NoOpTracer and _NoOpTracerProvider classes #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
codeboten opened this issue Jan 11, 2022 · 3 comments · Fixed by #2363
Closed

Add _NoOpTracer and _NoOpTracerProvider classes #2362

codeboten opened this issue Jan 11, 2022 · 3 comments · Fixed by #2363
Assignees
@codeboten
Labels
feature-request

Comments

@codeboten
Copy link
Contributor

As per @ocelotl's comment here the name _Default* doesn't make it clear what the behaviour is. This issue suggests creating new classes (_NoOpTracer and _NoOpTracerProvider) and marking _DefaultTracer & _DefaultTracerProvider as deprecated.
@codeboten codeboten self-assigned this Jan 11, 2022
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this issue Jan 11, 2022
Add _NoOpTracer and _NoOpTracerProvider classes
72aad22 
Add `_NoOpTracer` and `_NoOpTracerProvider`. Marking `_DefaultTracer` and `_DefaultTracerProvider` as deprecated.

Fixes open-telemetry#2362
@codeboten codeboten mentioned this issue Jan 11, 2022
Merged
4 tasks
@srikanthccv
Copy link
Member

Maybe controversial opinion. Do we have to change this? I understand it is not descriptive but these are private classes in api. OTEL makes it clear that in the absence of sdk everything is no-op which I could say default behaviour of the api tracer 🤷.

@lzchen
Copy link
Contributor

lzchen commented Jan 13, 2022

@lonewolf3739
I think this is also a fair point.

@owais
Copy link
Contributor

owais commented Jan 13, 2022

IMO the implementation/behavior should decide the name of an entity, not where/how it is consumed so noop makes sense to me to over default and since this is internal, changing it should be pretty straightforward while keeping an alias.

codeboten pushed a commit to codeboten/opentelemetry-python that referenced this issue Jan 14, 2022
Add _NoOpTracer and _NoOpTracerProvider classes
9892e47 
Add `_NoOpTracer` and `_NoOpTracerProvider`. Marking `_DefaultTracer` and `_DefaultTracerProvider` as deprecated.

Fixes open-telemetry#2362
ocelotl pushed a commit that referenced this issue Jan 17, 2022
Add NoOpTracer and NoOpTracerProvider classes (#2363)
1a52e9d 
* Add _NoOpTracer and _NoOpTracerProvider classes

Add `_NoOpTracer` and `_NoOpTracerProvider`. Marking `_DefaultTracer` and `_DefaultTracerProvider` as deprecated.

Fixes #2362

* update changelog

* update class

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add NoOpTracer and NoOpTracerProvider classes codeboten/opentelemetry-python
4 participants
@owais @codeboten @lzchen @srikanthccv