-
Notifications
You must be signed in to change notification settings - Fork 706
Warning message Calling set_status() on an ended span
in examples and tests
#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ocelotl As I can see another bug correlated with this: default status of ended span must be 'OK' according to spec https://github.com/open-telemetry/opentelemetry-specification/blob/ccbf36374730488548703a65af40d9051d7ab944/specification/api-tracing.md#set-status, but now it's |
Thanks for reporting, @condorcet . We are aiming to have the span status set to |
Describe your environment
Python 3.6, 3.7, 3.8
Code in master, hash: a89bbc8
Steps to reproduce
Add logging to stdout in pytest.ini
and run tests
OR
Run tracing example https://github.com/open-telemetry/opentelemetry-python/tree/8fa21e6bcbb0b28917039661ca2ba369d0dee6b2#tracing
What is the expected behavior?
No warning messages in positive tests and examples.
What is the actual behavior?
Multiple warning logs:
opentelemetry.sdk.trace:__init__.py:287 Calling set_status() on an ended span.
Additional context
It happens because we call
set_status
after ending a spanopentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
Line 268 in 8fa21e6
opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
Line 286 in 8fa21e6
The text was updated successfully, but these errors were encountered: