-
Notifications
You must be signed in to change notification settings - Fork 706
Decide on one (or more) formats for configuration files #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My 2cents: Supporting more than 1 format is a bad idea, users will be confused about with one is the correct one and what are the differences, we should also maintain them... About the formats, I'd discard JSON because it doesn't support comment, I'd also discard INI because it only supports one level hierarchy tree. About the remaining ones I think |
Would love to see some progress on this discussion.... could we vote: 👍 JSON |
I thing I'll call out that json and ini files I'd explicitly vote against. ini files have no ability to do nested data structures, and as a result you end up writing a hacky way to express them. json is hard to read and fairly error-prone (the fact that trailing commas are not allowed and error messages don't make that clear has made hand-editing json a trial, IME). |
worth nothing the collector uses |
Seems like the decision is between |
I voted YAML but I don't want to be the tie breaker lol |
|
Does this mean that we can decide for YAML? |
+1 for YAH-mal |
It seems like YAML is the chosen one. Can we close this issue? |
…metry#564) * docs: add usage for mongodb-core plugin open-telemetry#543 * Update packages/opentelemetry-plugin-mongodb-core/README.md Co-Authored-By: Mayur Kale <[email protected]>
This issue is related to #555
#466 introduced a configuration manager. Currently, it only reads from environment variables. For configuration files to be read, then it is necessary to define a few things first:
Here are some formats for consideration:
Please leave your thoughts about this in the comments below.
The text was updated successfully, but these errors were encountered: