Skip to content

Fix several configuration issues #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ocelotl opened this issue Apr 15, 2020 · 0 comments · Fixed by #583
Closed

Fix several configuration issues #582

ocelotl opened this issue Apr 15, 2020 · 0 comments · Fixed by #583
Assignees
@ocelotl
Labels
bug Something isn't working

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Apr 15, 2020

Fix the pending issues in #563 as pointed out by @mauriciovasquezbernal.
@ocelotl ocelotl added the bug Something isn't working label Apr 15, 2020
@ocelotl ocelotl self-assigned this Apr 15, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 15, 2020
@ocelotl
Add several configuration related fixes
0eb9baf 
Fixes open-telemetry#582
@ocelotl ocelotl mentioned this issue Apr 15, 2020
Merged
toumorokoshi pushed a commit that referenced this issue Apr 27, 2020
@ocelotl
api: Add several configuration related fixes (#583)
5d675ee 
Fixes #582

This makes the attributes of the configuration object case sensitive in order to match better the environment variables that are too.

This makes the attributes of the configuration object accept any legal Python variable name (Configuration().some_2_attribute) is valid now.

This makes non-defined attributes return None when queried instead of raising an AttributeError. This makes it easier to use the configuration object because the user won't have to check for the existence of the attribute beforehand:

if Configuration().some_attribute == "value":
    # do stuff

instead of

if hasattr(Configuration(), "some_attribute") and Configuration().some_attribute == "value":
    # do stuff
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan @mayurkale22
Named Tracers / Tracer Registry (open-telemetry#582)
18c6aa4 
* feat: spike of named tracer registry

* chore: mysql/mongo tracer registry support

* fix: lint

* chore: add getTracer back

* chore: change default tracer name to empty string

* fix: lint

* chore: update examples for registry

* chore(tracer-registry): make name required

* chore: lint

* chore: update examples for required tracer name

* chore: remove unused tracer delegate

* chore: remove references to basic tracer

* chore: remove references to NodeTracer

* chore: update xhr for tracer registry

* chore: update tracer names to match package names

* chore: add version script to all packages

* chore: update plugins to use version script

* chore: add jsdoc to noop tracer registry

* chore: update ioredis for tracer registry

* chore: update pg pool for tracer registry

* fix: lint

* chore: fix tests

* chore: lint

* chore: lint

Co-authored-by: Mayur Kale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add several configuration related fixes ocelotl/opentelemetry-python
1 participant
@ocelotl