Skip to content

Align Sampling API with specs #906

Closed
@lzchen

Description

@lzchen

Looks like Sampling "API' is actually defined as part of the SDK.

As well, there are some implementation details that are possibly deviating from the spec.
For example, spans set with is_recording_events to False are currently not even started/ended. According to the spec, it seems the spans should still be passed onto the processor but not the exporter (if is_sampled flag is set).

Also, the is_recording_events field seems to be always returning True as part of the SDK. We probably need this to be an actual property of the span.

Metadata

Metadata

Assignees

Labels

release:required-for-gaTo be resolved before GA releasesdkAffects the SDK package.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions