-
Notifications
You must be signed in to change notification settings - Fork 710
Add a Gitter chat badge to README.md #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I doubt this robot will ever sign off a CLA =) |
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 3, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 3, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 9, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 10, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 10, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 10, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
owais
referenced
this pull request
in owais/opentelemetry-python
Nov 10, 2020
According to opentracing semantic conventions, span.kind attribute should be one of the following four values: "server", "client", "producer", "consumer". The spec does not mention the casing of the strings but all examples show them in lower case. Moreoever, the OpenTelemetry collector recognizes these values only when they are lower case. Today if opentelemetry-python exports a span using the jaeger exporter to the OpenTelemetry collector, it loses the span.kind information. Using the debug logger exporter in the collector prints the following to the screen: Span #0 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : a6398bc507d8a982 ID : 4a00eaa815e69785 Name : span Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.684287 +0530 IST End time : 2020-11-03 18:06:29.684344 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 31789e02d79452eaedb72769bed5fac7 Parent ID : ID : a6398bc507d8a982 Name : HelloWorldResource.on_get Kind : SPAN_KIND_UNSPECIFIED Start time : 2020-11-03 18:06:29.683881 +0530 IST End time : 2020-11-03 18:06:29.684421 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : After the patch, span kind is correctly understood and represented by the collector: Span #0 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : 13f4cc8db8dfe5b3 ID : e8032193bb9dca98 Name : span Kind : SPAN_KIND_INTERNAL Start time : 2020-11-03 18:03:39.964796 +0530 IST End time : 2020-11-03 18:03:39.964857 +0530 IST Status code : STATUS_CODE_CANCELLED Status message : Span #1 Trace ID : 8e4aeaa621f7e67c813a9cf26c56a202 Parent ID : ID : 13f4cc8db8dfe5b3 Name : HelloWorldResource.on_get Kind : SPAN_KIND_SERVER Start time : 2020-11-03 18:03:39.964335 +0530 IST End time : 2020-11-03 18:03:39.964936 +0530 IST Status code : STATUS_CODE_CANCELLED Status message :
This was referenced Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-telemetry/opentelemetry-python now has a Chat Room on Gitter
@bogdandrutu has just created a chat room. You can visit it here: https://gitter.im/open-telemetry/opentelemetry-python.
This pull-request adds this badge to your README.md:
If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.