-
Notifications
You must be signed in to change notification settings - Fork 709
Fix race in set_tracer_provider()
#2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
30ba497
Fix race in set_tracer_provider
aabmass a1db8e7
Merge branch 'main' into set-tracer-provider-race
ocelotl eca6228
refactor _reset_globals to a test util
aabmass f73ad25
get rid of "Mixin" name and simplify code a bit
aabmass 8a13da5
add some comments to concurrency_test.py
aabmass 3e8cab9
actually respect log option
aabmass 4a6141b
Merge branch 'main' into set-tracer-provider-race
lzchen b0c90bc
Merge branch 'main' into set-tracer-provider-race
owais File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
from threading import Lock | ||
from typing import Callable | ||
|
||
|
||
class Once: | ||
owais marked this conversation as resolved.
Show resolved
Hide resolved
owais marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"""Execute a function exactly once and block all callers until the function returns | ||
|
||
Same as golang's `sync.Once <https://pkg.go.dev/sync#Once>`_ | ||
""" | ||
|
||
def __init__(self) -> None: | ||
self._lock = Lock() | ||
self._done = False | ||
|
||
def do_once(self, func: Callable[[], None]) -> bool: | ||
"""Execute ``func`` if it hasn't been executed or return. | ||
|
||
Will block until ``func`` has been called by one thread. | ||
|
||
Returns: | ||
Whether or not ``func`` was executed in this call | ||
""" | ||
|
||
# fast path, try to avoid locking | ||
if self._done: | ||
return False | ||
|
||
with self._lock: | ||
if not self._done: | ||
func() | ||
self._done = True | ||
return True | ||
return False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.