Remove obsolete version requirement for pytest #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
requested review from
a-feld,
carlosalberto,
lzchen,
Oberon00,
reyang and
toumorokoshi
as code owners
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 86.05% 86.05%
=======================================
Files 33 33
Lines 1628 1628
Branches 182 182
=======================================
Hits 1401 1401
Misses 181 181
Partials 46 46Continue to review full report at Codecov.
|
toumorokoshi
approved these changes
Dec 5, 2019
|
As you already said:
so I would prefer if we reworded the PR title, e.g. to "Remove obsolete version requirement for pytest", since we are already using latest. |
c24t
changed the title
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…y#317) closes open-telemetry#316 Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick update to #293 now that pytest-dev/pytest#6194 is fixed.
Note that there wouldn't be any harm in leaving the required version as is: users should pick up the latest version (
5.3.1as of this writing) which include the fix in either case.