Skip to content

build: adding sdist to build scripts #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

build: adding sdist to build scripts #433

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7228a
build: adding sdist to build scripts
toumorokoshi Feb 19, 2020
f970efc
Remove build/ dirs after build
c24t Feb 20, 2020
2c96fd5
build: removing --user flag
toumorokoshi Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,16 @@ BASEDIR=$(dirname $(readlink -f $(dirname $0)))

for d in opentelemetry-api/ opentelemetry-sdk/ ext/*/ ; do
(
echo "building $d"
cd "$d"
python3 setup.py --verbose bdist_wheel --dist-dir "$BASEDIR/dist/"
# some ext directories (such as docker tests)
# are not intended to be packaged. Verify the
# intent by looking for a setup.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this still builds opentelemetry-ext-testutil-0.4.dev0.tar.gz.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not publish testutil? I'm not sure the right market to set in that case, although maybe we should just move to a separate directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it seems like we should publish it, as the extensions need it to run tests, and it'd be frustrating I think to not be able to not be able to run tests without installing a package that only exists in a source tree.

if [ -f setup.py ]; then
python3 setup.py --verbose bdist_wheel --dist-dir "$BASEDIR/dist/" \
sdist --dist-dir "$BASEDIR/dist/" \
clean --all
fi
)
done
)