Skip to content

Config module doc fixes #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 14, 2020
Merged

Conversation

c24t
Copy link
Member

@c24t c24t commented Mar 14, 2020

Add the new configuration module from #466 to the generated docs and fix the docstring so it renders nicely:

docs_screenshot

@c24t c24t requested a review from a team March 14, 2020 20:39
@codecov-io
Copy link

codecov-io commented Mar 14, 2020

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #487   +/-   ##
======================================
  Coverage    89.2%   89.2%           
======================================
  Files          43      43           
  Lines        2177    2177           
  Branches      243     243           
======================================
  Hits         1942    1942           
  Misses        165     165           
  Partials       70      70
Impacted Files Coverage Δ
...ry-api/src/opentelemetry/configuration/__init__.py 86.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1aa28...016e5a0. Read the comment docs.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding a screenshot of the docs in the PR!

Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c24t c24t merged commit 71c0c83 into open-telemetry:master Mar 14, 2020
@c24t c24t deleted the config-module-doc-fixes branch March 14, 2020 22:29
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
* fix(grpc): use correct supportedVersions

* chore: use more clear semver

* chore: use more clear semver

* fix: incorrect file changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants