-
Notifications
You must be signed in to change notification settings - Fork 706
Config module doc fixes #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Mauricio Vásquez <[email protected]>
Co-Authored-By: Mauricio Vásquez <[email protected]>
Co-Authored-By: Chris Kleinknecht <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
======================================
Coverage 89.2% 89.2%
======================================
Files 43 43
Lines 2177 2177
Branches 243 243
======================================
Hits 1942 1942
Misses 165 165
Partials 70 70
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding a screenshot of the docs in the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix(grpc): use correct supportedVersions * chore: use more clear semver * chore: use more clear semver * fix: incorrect file changed
Add the new configuration module from #466 to the generated docs and fix the docstring so it renders nicely: