OpenAndroidInstaller does not drop to bootloader unlock in download mode on Samsung S10

[marmotte32]

Describe the bug
At after clicking on 'Confirm and run' at step ''Unlock the bootloader', the device reboot in download mode without the option to unlock the bootloader.

To Reproduce
Steps to reproduce the behavior:

1. Run OpenAndroidInstaller 0.4.4 beta
2. Click on 'I understand', click on 'Let's Start'
3. Click on 'Search for device', the device is detected 'beyond1lte', click 'Continue'
4. Tick the box 'requiered version of android installed' + 'battery level over 80%' + No lock ...', click 'Continue'
5. Select an OS image, select a recovery image, click 'Continue' (just a little bug, the file selection popup does not open foreground ...)
6. then now you are at the menu 'Unlock the bootloader', there is the issue, click 'Confirm and run'
   
7. The phone will reboot in download mode without the option to unlock the bootloader:
   

Expected behavior
I should reboot in bootloader unlock mode to be able to unlock the bootloader (long press volume up

Log file
openandroidinstaller.log

Screenshots
The phone will reboot in download mode without the option to unlock the bootloader:

Desktop (please complete the following information):

• OS: Linux Mint Cinnamon
• Version: 21.2

Smartphone (please complete the following information):

• Device: Samsung Galaxy S10 / codename: beyond1lte / model: SM-G973F/DS
• OS: Original Stock Samsung ROM installed is Android 12:
• Version A12
  AP/PDA: G973FXXSGHWC1 (PDA)
  CSC: G973FOXJGHVJ4
  CP: G973FXXSGHWB3 (BaseBand)

Additional context
It seems that the command adb reboot download does not show the expected unlock bootloader option
I did some test and was not able to get the right screen using adb.
It seems that on Samsung devices (at least S10), you really need to that manually to get the option to unlock the bootloader:
"With the device powered off - hold Volume Down + Bixby and connect USB cable to PC"

[MagicLike]

See #229 (comment)

[freechelmi]

I don't have a device of that samsung period to test but I think you are right .

We have to :

• Decide when samsung introduce the "manual" oem unlock ( S9 era I guess )
• Create a new image " Samsung Button Bixby Download cold" to explain how to manually boot to download mode
• Create the step to explain that the user should choose unlock with your screenshot

Generally the " unlock oem" although very important is not really well supported as each device has its own mechanism and UI in fastboot/download mode so your feedback is really important

[tsterbak]

Instructions can be found here: https://wiki.lineageos.org/devices/beyond1lte/install#pre-install-instructions
This should be fixable by adding bootloader unlocking steps to the respective config.

[marmotte32]

Hello,

@tsterbak
These instructions from LOS doc for recovery flash are wrong.
If you flash only the recovery then you'll end up on a vbmeta lock !

Carefully, when flahing the recovery the vbmeta-disabled IMG must be flashed at the same time.

Then regarding the bootloader unlock, yes it seems that this can not be triggered from any adb command.

So as suggested by @freechelmi it would be necessary to tell the enduser how to do it manually using some screenshots to access download mode after having set OEM unlock to enabled in Android dev options.

The bootloader must be unlocked before injecting any recovery.

[tsterbak]

Hi, thanks a lot for the clarification!
Twrp mentions this here: https://twrp.me/samsung/samsunggalaxys10.html
So we need to make it possible to flash the vbmeta.img before even touching the recovery.

As far as I know, the S10 line is the first generation of Samsung devices affected by this. Are there any other devices with this issue?

So we need to make it possible to flash the vbmeta.img before even touching the recovery.

It's easy to do with #220, just invert instructions in device configuration file

[tsterbak]

It's easy to do with #220, just invert instructions in device configuration file

True to some extend, but Samsung devices don't have a fastboot mode. So it needs to be done with heimdall (which should be possible)

Ok, I was not aware of that.

[marmotte32]

Here are the instructions for unlock and recovery + vbmeta Disabler :
https://forum.xda-developers.com/t/recovery-official-3-6-1-x-twrp-for-galaxy-s10-e-5g-exynos.4180287/

Please read the heimdall instruction but once unlocked, in download mode:
sudo heimdall flash --RECOVERY /path/to/recovery.img --VBMETA /path/to/vbmetaavbdisabled.img

[marmotte32]

And only if coming from a full stock ROM, the encryption need to be disabled by flashing this zip from twrp:
multidisabler-samsung-3.*.zip

Please note that I didn't tried nor the erecovery nor the losrecovery
I'm using twrp