remove secret variables #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

skvark merged 1 commit into opencv:master from native-api:remove_secure_variables

Nov 23, 2018

Contributor

native-api commented Nov 15, 2018

Would you consider moving secret variables into Travis settings?

Without secret variables in play, build output is not piped to a filter script, which:

gives no buffering, fancy colors and pseudographics in output;
avoids output loss due to after_failure output gets truncated unless sleep is used travis-ci/travis-ci#6018. I was hit by it numerous times (see references after after_failure output gets truncated unless sleep is used travis-ci/travis-ci#6018 (comment));
brew prints some status messages only if stdout is a tty, so there's no way to get them with secret variables present.


          remove secure variables

85364d3

Member

skvark commented Nov 23, 2018

I moved them to Travis settings.

skvark merged commit 57e49cb into opencv:master

native-api deleted the remove_secure_variables branch

November 24, 2018 21:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet