Skip to content

RHOAIENG-20241: fix the CI check for the runtime image definition #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Apr 10, 2025

https://issues.redhat.com/browse/RHOAIENG-20241

Description

This waits on #943 being merged.

How Has This Been Tested?

./ci/check-runtime-images.sh

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jstourac jstourac force-pushed the fixRuntimeImageCheck branch from 0f639a8 to 35d6e9d Compare April 10, 2025 12:02
@openshift-ci openshift-ci bot added size/m and removed size/m labels Apr 10, 2025
@jstourac jstourac marked this pull request as ready for review April 10, 2025 12:03
@openshift-ci openshift-ci bot requested review from andyatmiami and jiridanek April 10, 2025 12:03
@jstourac
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member

/lgtm

@jstourac
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Apr 11, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a2d91e6 into opendatahub-io:main Apr 11, 2025
11 checks passed
@jstourac jstourac deleted the fixRuntimeImageCheck branch April 11, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants