-
Notifications
You must be signed in to change notification settings - Fork 89
NO-JIRA: fix(pydantic_schemas): new podman version changed output of podman info
#1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: fix(pydantic_schemas): new podman version changed output of podman info
#1032
Conversation
Thanks for this Jiri; is this backward compatible or shall we be sure all team-members are on some decent version of podman? |
It strictly expands the set of jsons that will be parsed without error, so yes, backwards compatible. |
Here's docs for the |
Yeah, |
18eafa7
to
54e2ebd
Compare
…`podman info` Schema needs to be updated to also handle a `list[str]` value that may now be present.
54e2ebd
to
3c3e788
Compare
/lgtm |
/approve /override ci/prow/images |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Schema needs to be updated to also handle a
list[str]
value that may now be present.Description
How Has This Been Tested?
Pytest tests work on my machine now whereas before they would fail with pydantic validation error.
Merge criteria: