Skip to content

RHOAIENG-24981: Updated codeflare sdk versions and shas for v0.28.1 #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

kryanbeane
Copy link
Contributor

@kryanbeane kryanbeane commented May 14, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@kryanbeane
Copy link
Contributor Author

fixing conflicts

@kryanbeane
Copy link
Contributor Author

@atheo89 thanks for the pointers, should be all up to date now!

@atheo89
Copy link
Member

atheo89 commented May 14, 2025

@atheo89 thanks for the pointers, should be all up to date now!

Great! Thank you for the fast update 🙂
What about the tensorflow runtime? Is the only missing part. Does it have conflicts with the other packages?

@openshift-ci openshift-ci bot added size/l and removed size/l labels May 14, 2025
@kryanbeane
Copy link
Contributor Author

@atheo89 thanks for the pointers, should be all up to date now!

Great! Thank you for the fast update 🙂 What about the tensorflow runtime? Is the only missing part. Does it have conflicts with the other packages?

Oops missed that, I was searching for 0.27.0 to find what to update. Weird that the tensor flow runtime wasn't updated in the past. Shouldn't be any conflicts with other packages, I will double check with the team and if not I will update it

@atheo89 atheo89 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 14, 2025
@kryanbeane
Copy link
Contributor Author

kryanbeane commented May 14, 2025

hey @atheo89 two question:

  • is there an easy way to run pipenv lock on a mac but for CUDA runtime images? I am trying to lock dependencies for the pytorch runtime image and only way I could get it going was to start a docker container and run it from inside that but had to mess with the torchvision package (change 0.21.0+cu126 to 0.21.0) to get it working which I'd imagine isnt recommended. Any way you guys do it?
  • It turns out the tensorflow one wasn't updated because of an issue with tf2onnx package dependency resolution (see here). It looks like a workaround was added a while back (see here) so just looking for some confirmation that it should be okay to update codeflare sdk despite that?

Thanks!

EDIT: I managed a hacky workaround with docker and managed to run pipenv lock --verbose --pre --clear on all runtimes and also updated the tensor flow one as I believe the previous issue is gone now! Thanks

@jstourac
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jstourac. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/xxl and removed size/xxl labels May 15, 2025
@jstourac
Copy link
Member

thank you

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 15, 2025
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@kryanbeane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rocm-runtimes-ubi9-e2e-tests 7b4c07a link true /test rocm-runtimes-ubi9-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jiridanek jiridanek merged commit 4011c07 into opendatahub-io:main May 15, 2025
32 of 36 checks passed
@kryanbeane kryanbeane deleted the odh-sync branch May 15, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/xxl tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants