Skip to content

NO-JIRA: tests(gha): fix podman.sock cleanup in system reset for build workflow #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented May 19, 2025

Fixes #1120

Description

The podman system reset command in version 5.5.0 no longer removes the API socket and its containing directory, leading to stale permissions on the directory. Added a manual step to delete the podman.sock containing directory to ensure a clean environment. This change enhances reliability in the build workflow.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

…d workflow

The podman system reset command in version 5.5.0 no longer removes the API socket, leading to potential conflicts. Added a manual step to delete the podman.sock file to ensure a clean environment. This change enhances reliability in the build workflow.
@openshift-ci openshift-ci bot requested review from daniellutz and dibryant May 19, 2025 20:29
Copy link
Contributor

openshift-ci bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign daniellutz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/s and removed size/s labels May 19, 2025
@jstourac
Copy link
Member

/lgtm

@jiridanek jiridanek merged commit 1b6592f into opendatahub-io:main May 20, 2025
9 of 10 checks passed
@jiridanek jiridanek deleted the jd_podman_550 branch May 20, 2025 09:15
@jiridanek
Copy link
Member Author

/cherrypick 2024b

Copy link
Contributor

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
unknown `Object 'Kind' is missing in '

List of images referenced from the Python code generation scripts for Tekton pipelines.

The structure of this file must be compatible with

https://docs.renovatebot.com/modules/manager/tekton/

Specifically, see function getDeps and function getBundleValue() in

https://github.com/renovatebot/renovate/blob/main/lib/modules/manager/tekton/extract.ts

This is using the 'older-style' bundle references (see ^^^), because they are a bit less verbose

Konflux (MintMaker) will then update the hashes in this yaml together with the generated Tekton pipelines

because the default renovate.json config includes .tekton/**.yaml (and .yml) files

https://github.com/konflux-ci/mintmaker/blob/289fefb5c7ac18c978b96080c2628d55d0712e83/config/renovate/renovate.json#L62-L70

items:

  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-buildah-remote-oci-ta:0.4@sha256:1d26a89f1ad48279999cdcad3cb5ce43dc08620a6c07d8dfe5cc9c9e17622551
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-show-sbom:0.1@sha256:04f15cbce548e1db7770eee3f155ccb2cc0140a6c371dc67e9a34d83673ea0c0
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-init:0.2@sha256:737682d073a65a486d59b2b30e3104b93edd8490e0cd5e9b4a39703e47363f0f
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta:0.1@sha256:9709088bf3c581d4763e9804d9ee3a1f06ad6a61c23237277057c4f0cdc4f9c3
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-prefetch-dependencies-oci-ta:0.2@sha256:153ef0382deef840d155f5146f134f39b480523a7d5c38ba9fea2b58792dd4b5
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-build-image-index:0.1@sha256:95be274b6d0432d4671e2c41294ec345121bdf01284b1c6c46b5537dc6b37e15
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-source-build-oci-ta:0.2@sha256:9fe82c9511f282287686f918bf1a543fcef417848e7a503357e988aab2887cee
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-deprecated-image-check:0.5@sha256:5d63b920b71192906fe4d6c4903f594e6f34c5edcff9d21714a08b5edcfbc667
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-clair-scan:0.2@sha256:712afcf63f3b5a97c371d37e637efbcc9e1c7ad158872339d00adc6413cd8851
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-ecosystem-cert-preflight-checks:0.2@sha256:00b13d06d17328e105b11619ee4db98b215ca6ac02314a4776aa5fc2a974f9c1
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-sast-snyk-check-oci-ta:0.3@sha256:a1cb59ed66a7be1949c9720660efb0a006e95ef05b3f67929dd8e310e1d7baef
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-clamav-scan:0.2@sha256:62c835adae22e36fce6684460b39206bc16752f1a4427cdbba4ee9afdd279670
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-sast-coverity-check-oci-ta:0.2@sha256:044412899f847dad17a64ae84f43ace5fd6fb976acbe64a42eb0a06bbff92499
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-coverity-availability-check:0.2@sha256:0b35292eed661c5e3ca307c0ba7f594d17555db2a1da567903b0b47697fa23ed
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-sast-shell-check-oci-ta:0.1@sha256:a591675c72f06fb9c5b1a3d60e6e4c58e4df5f7da180c7a4691a692a6e7e6496
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-sast-unicode-check-oci-ta:0.1@sha256:424f2f659c02998dc3a43e1ce869e3148982c59adb74f953f8fa91ff1c9ab86e
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-apply-tags:0.1@sha256:61c90b1c94a2a11cb11211a0d65884089b758c34254fcec164d185a402beae22
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-push-dockerfile-oci-ta:0.1@sha256:55a4ff2910ae2e4502f3841719935d37578bd52156bc789fcdf45ff48c2b048b
  • spec:
    taskRef:
    bundle: quay.io/konflux-ci/tekton-catalog/task-rpms-signature-scan:0.2@sha256:7b80f5a319d4ff1817fa097cbdbb9473635562f8ea3022e64933e387d3b68715

'` |

@openshift-cherrypick-robot
Copy link
Contributor

@jiridanek: new pull request created: #1193

In response to this:

/cherrypick 2024b

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants