-
Notifications
You must be signed in to change notification settings - Fork 95
Add rocm runtimes to python 3.11 runtime-images folder #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Diamond, could you update the hash with the one of the suggestion?
jupyter/datascience/ubi9-python-3.11/runtime-images/rocm-pytorch-ubi9-py311.json
Outdated
Show resolved
Hide resolved
/lgtm |
"display_name": "Pytorch with ROCm and Python 3.11 (UBI9)", | ||
"metadata": { | ||
"tags": [ | ||
"rocm-pytorch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether we want the tags defined this way or whether we would like to have them as separate instead:
[ "rocm", "pytorch" ]
🤔
But I guess that these images are build together with ROCm for some reason, so probably having it as one tag makes sense 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89, jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Override the following tests since are not related to the changes /override ci/prow/images |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
83ccdb5
into
opendatahub-io:main
…lux/component-updates/component-update-odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22 Update odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22 to 1786483
Fixes for https://issues.redhat.com/browse/RHOAIENG-12637
Description
Include AMD runtime-images to python 3.11 based datascience notebook
How Has This Been Tested?
Merge criteria: