Skip to content

Add rocm runtimes to python 3.11 runtime-images folder #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

dibryant
Copy link
Contributor

Fixes for https://issues.redhat.com/browse/RHOAIENG-12637

Description

Include AMD runtime-images to python 3.11 based datascience notebook

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from atheo89 and jiridanek September 12, 2024 17:51
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Diamond, could you update the hash with the one of the suggestion?

@atheo89
Copy link
Member

atheo89 commented Sep 17, 2024

/lgtm
/approve

"display_name": "Pytorch with ROCm and Python 3.11 (UBI9)",
"metadata": {
"tags": [
"rocm-pytorch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we want the tags defined this way or whether we would like to have them as separate instead:

[ "rocm", "pytorch" ]

🤔

But I guess that these images are build together with ROCm for some reason, so probably having it as one tag makes sense 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it would help longer to tags them separate, as tags could be use to filter out runtimes images.
however as we currently are in earlier stages, keeping them as single tag would be more helpful.
Screenshot from 2024-09-17 15-28-32

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Member

atheo89 commented Sep 18, 2024

Override the following tests since are not related to the changes

/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests

In response to this:

Override the following tests since are not related to the changes

/override ci/prow/images
/override ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebook-rocm-jupyter-tf-ubi9-python-3-11-pr-image-mirror
/override ci/prow/notebooks-ubi9-e2e-tests
/override ci/prow/rocm-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 83ccdb5 into opendatahub-io:main Sep 18, 2024
18 checks passed
jesuino pushed a commit to jesuino/notebooks that referenced this pull request Jun 17, 2025
…lux/component-updates/component-update-odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22

Update odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22 to 1786483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants