RHOAIENG-16149: chore(Makefile): implement advice from avis-hansson.com/p/make/ #778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avis-hansson.com/p/make/ This way the Makefile will run even when /bin/sh is not Bash, and there are event more smaller benefits.
jiridanek
added
the
tide/merge-method-squash
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/images |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 tasks
jiridanek
added a commit
to jiridanek/notebooks
that referenced
this pull request
Dec 18, 2024
…avis-hansson.com/p/make/ (opendatahub-io#778) This way the Makefile will run even when /bin/sh is not Bash, and there are event more smaller benefits. (cherry picked from commit 4a1646b)
jiridanek
added a commit
to jiridanek/notebooks
that referenced
this pull request
Dec 19, 2024
…avis-hansson.com/p/make/ (opendatahub-io#778) This way the Makefile will run even when /bin/sh is not Bash, and there are event more smaller benefits. (cherry picked from commit 4a1646b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-16149
Description
This way the Makefile will run even when /bin/sh is not Bash, and there are event more smaller benefits.
How Has This Been Tested?
Merge criteria: