NO-JIRA: chore(.editorconfig): introduce .editorconfig file for the project
#809
Conversation
jiridanek
added
the
tide/merge-method-squash
|
/lgtm If I understand correctly - then e.g. for VS code, I need to install this plugin, right? Update: yeah, based on this, looks like that https://editorconfig.org/. |
There was a problem hiding this comment.
If I understand correctly - then e.g. for VS code, I need to install [this plugin] (https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig), right?
Update: yeah, based on this, looks like that https://editorconfig.org/.
yes, that one
There was a problem hiding this comment.
Update2: should we put some note about this somewhere in our readme (not only for a newcomers) to be aware of this?
Projects mostly don't mention this, for example vscode ohly has this comment on top of .editorconfig itself and that's that
# EditorConfig is awesome: https://EditorConfig.orgThere was a problem hiding this comment.
I would not mention it either, if we mentioned everything that could be mention, nobody would ever find strength of will to read our bloated readme.
There was a problem hiding this comment.
okay, I don't have strong opinion on this
There was a problem hiding this comment.
I wanted to also add the EditorConfig is awesome part, in order to improve our documentation (IMO it would make it more likely people open the link) but since I got lgtms already, I will merge what I have. Thanks for taking a look.
|
/override ci/prow/images These are irrelevant for this change. |
|
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/images These are irrelevant for this change. |
|
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…lux/component-updates/component-update-odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22 Update odh-workbench-jupyter-datascience-cpu-py311-ubi9-n-v2-22 to 5435e0f
https://editorconfig.org/
Description
How Has This Been Tested?
Works on my machine (in IntelliJ, but
.editorconfigis supported in all major editors).Merge criteria: