Pin jupyterlab package to version 4.2.6
#810
Conversation
|
/lgtm |
|
/retest |
|
Hi Guilherme, I know this change is small and straightforward, but I think we're not ready to commit only the Pipfiles without their corresponding Piplock files. I understand it’s a bit of a tedious process, but I have a solution that won’t require you to strain your PC. You just need to follow the comment I wrote on Diamond's PR link |
Wouldn't the automatic Tuesday piplock renewal github action take care of that? |
That's what I thought. Also, the Pipfile.lock files are already on the correct version ( |
Right, sorry I didn't notice that the pipfile.locks point already to 4.2.6! About the piplock renewal i just saw that it failed today while the cron firing, need to check. Seems that it can not ingest the py version. need to check |
|
I think i know what is happening i will open a pr to fix that, I don't have specify what to pick in case of no inputs |
|
/retest |
|
This is the fix for the cron firing: #811 So to unblock this /lgtm |
|
/override ci/prow/notebooks-ubi9-e2e-tests |
|
@caponetto: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caponetto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/rocm-notebooks-e2e-tests |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/notebooks-ubi9-e2e-tests |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/notebooks-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/images |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build" |
|
@caponetto: Overrode contexts on behalf of caponetto: build (cuda-jupyter-tensorflow-ubi9-python-3.11) / build, build (rocm-jupyter-tensorflow-ubi9-python-3.11) / build In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
|
@caponetto related info FYI: Jupyterlab 4 support is coming for upstream Elyra as well. |
|
@caponetto is a co-author on the PR, so I wouldn't worry he's not aware ;p 
|
|
/override ci/prow/notebooks-ubi9-e2e-tests |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/images |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/retest |
|
no joy, we'll have to override, me thinks /retest-required |
|
/override ci/prow/codeserver-notebook-e2e-tests |
|
@caponetto: Overrode contexts on behalf of caponetto: ci/prow/codeserver-notebook-e2e-tests, ci/prow/intel-notebooks-e2e-tests, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/rstudio-notebook-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
openshift-merge-bot
bot
merged commit 532f554
into
opendatahub-io:main
|
🥳 |
…lux/component-updates/component-update-odh-workbench-jupyter-minimal-cuda-py311-ubi9-n-v2-22 Update odh-workbench-jupyter-minimal-cuda-py311-ubi9-n-v2-22 to fb10bc3
Related to https://issues.redhat.com/browse/RHOAIENG-11156
Description
Pin
jupyterlabpackage to version4.2.6to avoid changes made on the base images being overridden due to JL upgrades. No need to update the Pipfile.lock files since they are already using the target version.How Has This Been Tested?
Merge criteria: