Skip to content

RHOAIENG-19051: chore(Makefile): remove dependency on bin/buildinputs for running image tests #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Mar 14, 2025

Found when enabling hypershift in

in support of https://issues.redhat.com//browse/RHOAIENG-19051

Description

Some CI jobs would fail when go is not present on the machine running the make validate% targets. This change avoids needing go just to run tests.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek
Copy link
Member Author

jiridanek commented Mar 15, 2025

/test codeserver-notebook-e2e-tests

[2/5] STEP 11/51: RUN NVIDIA_GPGKEY_SUM=d0664fbbdb8c32356d...c/pki/rpm-gpg/RPM-GPG-KEY-NVIDIA" | sha256sum -c --strict -
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to developer.download.nvidia.com:443 
/etc/pki/rpm-gpg/RPM-GPG-KEY-NVIDIA: FAILED
sha256sum: WARNING: 1 computed checksum did NOT match
error: build error: building at STEP "RUN NVIDIA_GPGKEY_SU...256sum -c --strict -": while running runtime: exit status 1 

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/opendatahub-io_notebooks/948/pull-ci-opendatahub-io-notebooks-main-codeserver-notebook-e2e-tests/1900899179761242112

@jiridanek
Copy link
Member Author

@jiridanek
Copy link
Member Author

/test codeserver-notebook-e2e-tests

1 similar comment
@jiridanek
Copy link
Member Author

/test codeserver-notebook-e2e-tests

@jiridanek jiridanek force-pushed the jd_makefile_prereq branch from 9232280 to 92d0b2a Compare March 15, 2025 14:02
@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 15, 2025
@jiridanek
Copy link
Member Author

/test codeserver-notebook-e2e-tests

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 15, 2025
@jiridanek
Copy link
Member Author

/test codeserver-notebook-e2e-tests

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels Mar 17, 2025
@atheo89
Copy link
Member

atheo89 commented Mar 17, 2025

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 97479e0 into opendatahub-io:main Mar 17, 2025
10 checks passed
@jiridanek jiridanek deleted the jd_makefile_prereq branch March 17, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants