feat: move HardwareProfile CRD to odh-operator #2001
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
carlkyrillos
force-pushed
the
RHOAIENG-25256
branch
from
f9e6648 to
422c821
Compare
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/15352479418 |
carlkyrillos
force-pushed
the
RHOAIENG-25256
branch
from
422c821 to
6264145
Compare
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/15352530000 |
carlkyrillos
force-pushed
the
RHOAIENG-25256
branch
from
6264145 to
0d035ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kueue-migration #2001 +/- ##
================================================
Coverage 26.91% 26.91%
================================================
Files 173 173
Lines 12071 12071
================================================
Hits 3249 3249
Misses 8537 8537
Partials 285 285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // The node selector available. | ||
| // +optional | ||
| NodeSelector map[string]string `json:"nodeSelector,omitempty"` |
There was a problem hiding this comment.
As follow up, I'd investigate if we can use the corev1.NodeSelector
| DisplayName string `json:"displayName"` | ||
|
|
||
| // Indicates whether the hardware profile is available for new resources. | ||
| Enabled bool `json:"enabled"` |
There was a problem hiding this comment.
As follow up, I'd investigate if this field still make sense
| // HardwareProfileSpec defines the desired state of HardwareProfile. | ||
| type HardwareProfileSpec struct { | ||
| // The display name of the hardware profile. | ||
| DisplayName string `json:"displayName"` |
There was a problem hiding this comment.
As follow up, I'd investigate if this could become an annotation
|
|
||
| // A short description of the hardware profile. | ||
| // +optional | ||
| Description string `json:"description,omitempty"` |
There was a problem hiding this comment.
As follow up, I'd investigate if this could become an annotation
|
|
||
| type HardwareIdentifier struct { | ||
| // The display name of identifier. | ||
| DisplayName string `json:"displayName"` |
There was a problem hiding this comment.
As follow up, I'd investigate if this still make sense
Description
JIRA: RHOAIENG-25256
This PR adds a new
HardwareProfileCRD (along with required RBAC, boilerplate code, etc.) to the odh-operator that is functionally identical to theHardwareProfileCRD from odh-dashboard. The only difference is odh-operator version of the CRD has a.statusblock which the dashboard version of the CRD does not have.How Has This Been Tested?
These changes were tested by building operator, bundle, and catalog images, then verifying that the DSC and DSCI CRs successfully reconcile. It was also verified that the new CRD,
hardwareprofiles.infrastructure.opendatahub.io, was created as expected.The following images were used for testing and can be used for verification:
Screenshot or short clip
Merge criteria