8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object

[alexmenkov]

The change fixes race in the test.
Tested thread is expected to have no contended monitor when main thread checks it, but System.out.println() can cause waiting on a monitor when concurrent printing is performed, so printing should not be performed after signalling main thread to continue.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• SendaoYan (@sendaoYan - Committer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25683/head:pull/25683
$ git checkout pull/25683

Update a local copy of the PR:
$ git checkout pull/25683
$ git pull https://git.openjdk.org/jdk.git pull/25683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25683

View PR using the GUI difftool:
$ git pr show -t 25683

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25683.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object

Reviewed-by: cjplummer, syan, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 3ff83ec: 8358159: Empty mode/padding in cipher transformations
• 7c9c8ba: 8356780: PhaseMacroExpand::_has_locks is unused
• ca7b885: 8358749: Fix input checks in Vector API intrinsics
• ... and 19 more: https://git.openjdk.org/jdk/compare/026975a1aa290613934ae421bbc56326627bad8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f96d7f83)

[plummercj]

Looks good.

[sendaoYan]

LGTM

[sspitsyn]

Looks good.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 8f487d2.
Since your change was applied there have been 25 commits pushed to the master branch:

• 500a3a2: 8358799: Refactor os::jvm_path()
• a2f99fd: 8354383: C2: enable sinking of Type nodes out of loop
• 0582bd2: 8357639: DigestEchoClient fails intermittently due to: java.io.IOException: Data received while in pool
• ... and 22 more: https://git.openjdk.org/jdk/compare/026975a1aa290613934ae421bbc56326627bad8d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 8f487d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.