Skip to content

8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null #25694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jun 9, 2025

Simple correction where API docs state a return value may be "null", but in fact this is a result of type long, and may be zero.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8359040 to be approved

Issues

  • JDK-8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null (Bug - P4)
  • JDK-8359040: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25694/head:pull/25694
$ git checkout pull/25694

Update a local copy of the PR:
$ git checkout pull/25694
$ git pull https://git.openjdk.org/jdk.git pull/25694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25694

View PR using the GUI difftool:
$ git pr show -t 25694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25694.diff

Using Webrev

Link to Webrev Comment

@kevinjwalls
Copy link
Contributor Author

/csr

@kevinjwalls kevinjwalls marked this pull request as ready for review June 9, 2025 13:16
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8358970 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kevinjwalls The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 9, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Pull request needs approved CSR before integration rfr Pull request is ready for review serviceability [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant