8358734: Remove JavaTimeSupplementary resource bundles #25699
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
| for (Iterator<Locale> itr = candidates.iterator(); itr.hasNext();) { | ||
| if (!adapter.isSupportedProviderLocale(itr.next(), langtags)) { | ||
| itr.remove(); | ||
| if (adapter instanceof JRELocaleProviderAdapter jlpa) { |
There was a problem hiding this comment.
For safety, should we have some type of failure if this is not true, similar to the previous CCE.
There was a problem hiding this comment.
I think this is acceptable. If, for some reason, adapter is not an instance, it will simply be ignored. That cast was a mere artifact from a time before we had this instanceof construct and we knew it wouldn't throw a CCE.
The parallel loading of JavaTimeSupplementary was a historical artifact from the introduction of JSR 310, which additionally loads resouces that had not existed before. Since the COMPAT locale provider which relied on this mechanism has been removed, and the CLDR resource bundles now include those resources by default, removing the parallel loading mechanism simplifies the implementation
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25699/head:pull/25699$ git checkout pull/25699Update a local copy of the PR:
$ git checkout pull/25699$ git pull https://git.openjdk.org/jdk.git pull/25699/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25699View PR using the GUI difftool:
$ git pr show -t 25699Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25699.diff
Using Webrev
Link to Webrev Comment