8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)

[AlanBateman]

On Windows, if a platform thread is blocked in SocketChannel.read, and another thread closes the channel, then Windows abruptly closes the connection (RST). In releases prior to JDK 11, the connection was shutdown for writing before closing so the connection was closed gracefully, an unexpected behavior change

implCloseBlockingMode is changed to shutdown the connection for writing on Windows, no change in behavior for other platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win) (Bug - P3)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Volkan Yazici (@vy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25700/head:pull/25700
$ git checkout pull/25700

Update a local copy of the PR:
$ git checkout pull/25700
$ git pull https://git.openjdk.org/jdk.git pull/25700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25700

View PR using the GUI difftool:
$ git pr show -t 25700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25700.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)

Reviewed-by: jpai, vyazici

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 9586817: 8359170: Add 2 TLS and 2 CS Sectigo roots
• 38b877e: 8358294: Remove unnecessary GenAlignment
• 8f487d2: 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object
• ... and 5 more: https://git.openjdk.org/jdk/compare/ca7b885873712a5ae503cb82c915d709034a69f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6a51ffc5)

[jaikiran]

The changes look good to me.

[vy]

Verified that

1. Only on Windows, implCloseNonBlockingMode() disallows further writes prior to tryClose()
2. Tests stress the ill behavior reported

[AlanBateman]

/integrate

[erikj79]

/touch

[openjdk]

Going to push as commit e5196fc.
Since your change was applied there have been 15 commits pushed to the master branch:

• c98dffa: 8357982: Fix several failing BMI tests with -XX:+UseAPX
• 7d7fc69: 8357570: [macOS] os::Bsd::available_memory() might return too low values
• 42ab8fc: 8265754: Move suspend/resume API from HandshakeState
• ... and 12 more: https://git.openjdk.org/jdk/compare/ca7b885873712a5ae503cb82c915d709034a69f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit e5196fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@erikj79 The command touch can only be used in open pull requests.