Skip to content

8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win) #25700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jun 9, 2025

On Windows, if a platform thread is blocked in SocketChannel.read, and another thread closes the channel, then Windows abruptly closes the connection (RST). In releases prior to JDK 11, the connection was shutdown for writing before closing so the connection was closed gracefully, an unexpected behavior change

implCloseBlockingMode is changed to shutdown the connection for writing on Windows, no change in behavior for other platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25700/head:pull/25700
$ git checkout pull/25700

Update a local copy of the PR:
$ git checkout pull/25700
$ git pull https://git.openjdk.org/jdk.git pull/25700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25700

View PR using the GUI difftool:
$ git pr show -t 25700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25700.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)

Reviewed-by: jpai, vyazici

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@AlanBateman The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman AlanBateman marked this pull request as ready for review June 10, 2025 13:34
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 11, 2025
Copy link
Contributor

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that

  1. Only on Windows, implCloseNonBlockingMode() disallows further writes prior to tryClose()
  2. Tests stress the ill behavior reported

@AlanBateman
Copy link
Contributor Author

/integrate

@erikj79
Copy link
Member

erikj79 commented Jun 11, 2025

/touch

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

Going to push as commit e5196fc.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 11, 2025
@openjdk openjdk bot closed this Jun 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 11, 2025
@openjdk
Copy link

openjdk bot commented Jun 11, 2025

@AlanBateman Pushed as commit e5196fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jun 11, 2025

@erikj79 The command touch can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio [email protected]
Development

Successfully merging this pull request may close these issues.

4 participants