-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win) #25700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that
- Only on Windows,
implCloseNonBlockingMode()
disallows further writes prior totryClose()
- Tests stress the ill behavior reported
/integrate |
/touch |
Going to push as commit e5196fc.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit e5196fc. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@erikj79 The command |
On Windows, if a platform thread is blocked in SocketChannel.read, and another thread closes the channel, then Windows abruptly closes the connection (RST). In releases prior to JDK 11, the connection was shutdown for writing before closing so the connection was closed gracefully, an unexpected behavior change
implCloseBlockingMode is changed to shutdown the connection for writing on Windows, no change in behavior for other platforms.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25700/head:pull/25700
$ git checkout pull/25700
Update a local copy of the PR:
$ git checkout pull/25700
$ git pull https://git.openjdk.org/jdk.git pull/25700/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25700
View PR using the GUI difftool:
$ git pr show -t 25700
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25700.diff
Using Webrev
Link to Webrev Comment