8351010: Test java/io/File/GetXSpace.java failed: / usable space 56380809216 > free space 14912244940

[bplb]

Relax testing the inequality usable_space <= free_space to testing the inequality usable_space <= total_space.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8351010: Test java/io/File/GetXSpace.java failed: / usable space 56380809216 > free space 14912244940 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25704/head:pull/25704
$ git checkout pull/25704

Update a local copy of the PR:
$ git checkout pull/25704
$ git pull https://git.openjdk.org/jdk.git pull/25704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25704

View PR using the GUI difftool:
$ git pr show -t 25704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25704.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

Although the native system call statfs (Unix) and native function GetDiskFreeSpaceExW (Windows) might collect the space values atomically at a given instant, the space values returned by getFreeSpace and getUsableSpace are obtained at two distinct times, hence the state of the file system might have changed in the intervening interval, and the inequality usable_space <= free_space cannot be reliably tested in a deterministic manner. This has caused many failures in the GetXSpace test, so it seems reasonable to relax the constrain to usable_space <= free_space. Other statistical methods could be used to test the original inequality usable_space <= free_space, but they all admit to some degree of randomness as to how much the file system might change in a small interval of time and are therefore open to (likely spurious) failures.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3ffd7206)