8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java #25705

DamonGuy · 2025-06-09T21:17:22Z

This change is to restore the original intent of the test by updating the instructions to check that the type of Cursor is preserved when clicked and dragged. Now the test correctly has instructions to check that an I-beam cursor stays an I-beam until released over a List with its cursor being updated to a Hand cursor.

There is a bug where this does not correctly update in macOS (found in JDK-7177297). So, this test needs to be problem-listed.

I have confirmed that preserving the cursor image when dragging is native behavior across macOS, Windows, and Ubuntu. And I have checked that the test passes on both Windows and Ubuntu, while macOS fails and immediately updates the cursor as it leaves the TextArea.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25705/head:pull/25705
$ git checkout pull/25705

Update a local copy of the PR:
$ git checkout pull/25705
$ git pull https://git.openjdk.org/jdk.git pull/25705/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25705

View PR using the GUI difftool:
$ git pr show -t 25705

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25705.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-09T21:18:05Z

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-09T21:18:08Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2025-06-09T21:18:34Z

@DamonGuy The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-09T21:23:49Z

Webrevs

01: Full - Incremental (b2f2fc54)
00: Full (467957ac)

honkar-jdk · 2025-06-10T00:36:24Z

test/jdk/ProblemList.txt

@@ -834,6 +834,7 @@ java/awt/Checkbox/CheckboxNullLabelTest.java 8340870 windows-all
 java/awt/dnd/WinMoveFileToShellTest.java 8341665 windows-all
 java/awt/Menu/MenuVisibilityTest.java 8161110 macosx-all
 java/awt/Modal/NativeDialogToFrontBackTest.java 7188049 windows-all,linux-all
+java/awt/Cursor/CursorDragTest/ListDragCursor.java 8359061 macosx-all


Did you mean to use 7177297 in problemlist entry?

Doesn't seem right either. There's a warning about this from the Skara bot.

Should I update the issue number here to 7177297? I'm not fully grasping the Skara bot's error message.

Currently, you problem-listing the test referencing the bug JDK-8359061, which is being fixed by this PR. Once you integrate it, JDK-8359061 will be resolved. Thus, the problem-list entry refers to the bug that's already resolved, which implies the problem why the test is problem-listed is addressed.

Yes, ListDragCursor.java is problem-listed because of JDK-7177297. When JDK-7177297 is fixed, the test will be removed from the problem list.

In other words, the bug id in the problem list refers to a JBS issue where the test failure is described, and that issue has to be open.

Makes sense. Thanks. I have updated the bugID in the PL.

honkar-jdk · 2025-06-10T00:42:21Z

test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java

+                If the mouse cursor starts as a Text Line Cursor (I-beam),
+                and does not change until you reached the List and
+                released the left mouse button (and becomes a Hand Cursor),
+                pass the test. This test fails if the cursor updates
+                when pointing over the different components before
+                dragging is complete.


The new instructions doesn't seem to hold true when I tested on windows.
Additionally the instructions require rephrasing for clarity?

Perhaps, the instructions need to be adjusted for each OS, or the test should be limited to a specific OS only.

It seems like there's a bug with this test when using it in a PassFailJFrame. When I move the createUI logic into a standalone java class's main method and add setVisible(true), the test works as expected for all OS's except macOS.

In this PassFailJFrame it looks like it "works" correctly for 1 second, and then the cursor updates anyway afterwards. I'm going to try to look into why this is, but is this what you are seeing too @honkar-jdk ?

I have attached the standalone test to the issue. I tried altering how ListDragCursor.java creates the UI but it seems that no matter what I do, the cursor still updates after 1 second. I'm looking into what PassFailJFrame does differently at the moment.

I guess it's not the first time that we've encountered such an issue where using PassFailJFrame changes the behaviour of the test. Was it @TejeshR13's test?

I'm confused because PassFailJFrame does nothing more than provides a standard UI. It uses Swing components to display UI. Could this affect AWT components?

We have to look into what may cause the differences in behaviour.

I have been looking at it and fiddling with the standalone (non-PassFailJFrame) test to see if I can re-create the behavior without PassFailJFrame. I suspected AWT components being the issue but I can't see why.

I tried using EventQueue and SwingUtilities invokeAndWait() method to see if either made a difference, but to no success. I tried different layouts for the frame but I got the same result. I'll keep looking but I may also append windows to the ProblemList temporarily if I cannot find the source in a reasonable amount of time.

Could it be that mere existence of other windows created by the same Java process somehow changes the cursors?

I mean PassFailJFrame displays another window. What if you create a second window (that may display nothing inside) in your stand-alone test? Does it change what cursors you see when dragging?

aivanov-jdk · 2025-06-10T13:19:40Z

test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java

+                If the mouse cursor starts as a Text Line Cursor (I-beam),
+                and does not change until you reached the List and
+                released the left mouse button (and becomes a Hand Cursor),
+                pass the test. This test fails if the cursor updates
+                when pointing over the different components before
+                dragging is complete.


Perhaps, the instructions need to be adjusted for each OS, or the test should be limited to a specific OS only.

aivanov-jdk · 2025-06-10T13:21:14Z

test/jdk/java/awt/Cursor/CursorDragTest/ListDragCursor.java

+                If the mouse cursor starts as a Text Line Cursor (I-beam),
+                and does not change until you reached the List and


Is it really how native applications behave on macOS?

At least on Windows, the cursor changes as soon as drag operation is started. The cursor shouldn't remain the I-beam when you drag from one component to another.

In Windows 11, I tried using the file explorer's search text field. It turns into an I-beam and stays one until I let go of the left mouse button. I also tried with Cisco's VPN settings button (cog wheel) that is a hand cursor and it behaves the same way. I also tried dragging from the file explorer's search field to Cisco's cog wheel and it stays an I-beam throughout.

In macOS, I used the search bar in Finder to get an I-beam and drag. It also stays an I-beam until released.

aivanov-jdk · 2025-06-10T13:21:58Z

test/jdk/ProblemList.txt

@@ -834,6 +834,7 @@ java/awt/Checkbox/CheckboxNullLabelTest.java 8340870 windows-all
 java/awt/dnd/WinMoveFileToShellTest.java 8341665 windows-all
 java/awt/Menu/MenuVisibilityTest.java 8161110 macosx-all
 java/awt/Modal/NativeDialogToFrontBackTest.java 7188049 windows-all,linux-all
+java/awt/Cursor/CursorDragTest/ListDragCursor.java 8359061 macosx-all


Doesn't seem right either. There's a warning about this from the Skara bot.

DamonGuy added 10 commits November 23, 2024 20:39

Initial commit for backout

c51406a

Merge branch 'master' of github.com:DamonGuy/jdk

a98fb87

Merge branch 'master' of github.com:DamonGuy/jdk

947f73d

Merge branch 'master' of github.com:DamonGuy/jdk

b17e483

Merge branch 'master' of github.com:DamonGuy/jdk

9583f8a

Merge branch 'master' of github.com:DamonGuy/jdk

d76baf5

Merge branch 'master' of github.com:DamonGuy/jdk

abd6ab9

Merge branch 'master' of github.com:DamonGuy/jdk

0824a98

Merge branch 'master' of github.com:DamonGuy/jdk

781a2ba

Initial commit

467957a

openjdk bot added the rfr Pull request is ready for review label Jun 9, 2025

openjdk bot added the client [email protected] label Jun 9, 2025

honkar-jdk reviewed Jun 10, 2025

View reviewed changes

aivanov-jdk reviewed Jun 10, 2025

View reviewed changes

Update PL num. Clarify instructions.

b2f2fc5

		If the mouse cursor starts as a Text Line Cursor (I-beam),
		and does not change until you reached the List and

8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java #25705

Are you sure you want to change the base?

8359061: Update and ProblemList manual test java/awt/Cursor/CursorDragTest/ListDragCursor.java #25705

Conversation

DamonGuy commented Jun 9, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper bot commented Jun 9, 2025

Uh oh!

openjdk bot commented Jun 9, 2025

Uh oh!

openjdk bot commented Jun 9, 2025

Uh oh!

mlbridge bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

honkar-jdk Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aivanov-jdk Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DamonGuy commented Jun 9, 2025 •

edited by openjdk bot

Loading

mlbridge bot commented Jun 9, 2025 •

edited

Loading

honkar-jdk Jun 10, 2025 •

edited

Loading

aivanov-jdk Jun 10, 2025 •

edited

Loading