8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object

[kevinjwalls]

The classes javax.management.AttributeList, and javax.management.relation.RoleList and UnresolvedRoleList, have a historical feature where they accept objects of the wrong type, and only check for wrong objects when the "asList()" method is called.

This feature should be removed, and these classes should never accept the wrong kind of Object.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8359917 to be approved

Issues

• JDK-8359809: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object (Enhancement - P4)
• JDK-8359917: AttributeList, RoleList and UnresolvedRoleList should never accept other types of Object (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25856/head:pull/25856
$ git checkout pull/25856

Update a local copy of the PR:
$ git checkout pull/25856
$ git pull https://git.openjdk.org/jdk.git pull/25856/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25856

View PR using the GUI difftool:
$ git pr show -t 25856

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25856.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@kevinjwalls The following labels will be automatically applied to this pull request:

• jmx
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[kevinjwalls]

/csr

[openjdk]

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8359809 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[kevinjwalls]

Removing the trailing dot from "parameter.", here and new line 247 below, to be in line with the rest.

[mlbridge]

Webrevs

• 00: Full (50904f10)

[sspitsyn]

Q: Is null allowed? The same question applies to the addAll() if these methods allow null to be present in the collection.

[kevinjwalls]

The intent here is not to change behaviour regarding nulls.
Nulls have been permitted, and should stay permitted.
Other object types (that don't cast to Role, in this file) should fail.

The Role related files are quite unusual to use, so expect they are mostly used only by the JDK.
MBean code might more commonly manipulate an AttributeList, and we can still permit nulls in case such code relies on nulls being accepted.

[sspitsyn]

My question was because there are checks for null in this class:

public void add(Role role)
        throws IllegalArgumentException {

        if (role == null) {
            throw new IllegalArgumentException("Invalid parameter");
        }
        checkTypeSafe(role);
        super.add(role);
    }

It is kind of confusing and not clear where null is allowed and where it is not.
Should it be more consistent?