8360045: StringTokenizer.hasMoreTokens() throws NPE after nextToken(null)

[naotoj]

Fixing the side-effect caused by calling StringTokenizer.nextToken(null), where the delimiter is set to null even if the method throws an NPE.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360045: StringTokenizer.hasMoreTokens() throws NPE after nextToken(null) (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25942/head:pull/25942
$ git checkout pull/25942

Update a local copy of the PR:
$ git checkout pull/25942
$ git pull https://git.openjdk.org/jdk.git pull/25942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25942

View PR using the GUI difftool:
$ git pr show -t 25942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25942.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360045: StringTokenizer.hasMoreTokens() throws NPE after nextToken(null)

Reviewed-by: liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• dbbfa76: 8131136: java/awt/font/JNICheck/JNICheck.sh issue warning on core-libs code
• 9af36b1: 8360307: Problemlist tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java
• 34412da: 8360179: RISC-V: Only enable BigInteger intrinsics when AvoidUnalignedAccess == false
• ... and 4 more: https://git.openjdk.org/jdk/compare/9c3eaa49f7f8c6ade7319064566c0370e955f631...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@naotoj The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0f536f0a)

[liach]

Indeed, looking at the spec, we would anticipate an exception means no change has been committed to a StringTokenizer.

[ExE-Boss]

Note that as mentioned in the bug discussion, the same also occurs when doing new StringTokenizer("some string", (String) null).

[AlanBateman]

Note that as mentioned in the bug discussion, the same also occurs when doing new StringTokenizer("some string", (String) null).

Right, and it's super weird, but seems to have been specified since JDK 5 to defer the NPE to later. I don't know if anything depends on that behavior but would be risky to change it now.