Support adding incubator modules via the Gradle plugin #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
I don't love this approach but there are some constraints:
_INCUBATOR
name. However, this exceeds the bounds of what's known, so perhaps this is not specifically necessary._INCUBATOR
attached) is not ideal. That's why there's an explicit boolean, defaultfalse
, that also indicates that it's an incubator.Other approaches considered:
I
.Map<String, JavaFXModule>
where the key is the module name and the record contains all the necessary data fields. I didn't think that was level of rewrite was necessarily beneficial, and it would raise the minimum Java version of the plugin from 11 to 16.