Skip to content

Addresses part of Recipes to upgrade to Spring Boot 3.4 #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 27, 2025

Conversation

wapkch
Copy link
Contributor

@wapkch wapkch commented Apr 23, 2025

What's changed?

  • Addresses part of Recipes to upgrade to Spring Boot 3.4 #642:
  • WebJars Locator Integration: instead of org.webjars:webjars-locator-core depend on org.webjars:webjars-locator-lite
  • Deprecations in RestTemplateBuilder
  • Bean configuration properties need to be marked with @Valid where previously only @validated was required see

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 23, 2025
@timtebeek timtebeek self-requested a review April 23, 2025 09:05
@timtebeek timtebeek added boot-3.4 recipe Recipe requested labels Apr 23, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/security5/WebSecurityConfigurerAdapter.java
    • lines 21-21

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/spring/security5/WebSecurityConfigurerAdapter.java
    • lines 21-21

@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Apr 24, 2025
@timtebeek
Copy link
Member

Thanks a lot already @wapkch ! I didn't find time to get this reviewed and merged before yesterday's release, but know it's appreciated and we'll get this in before the next run. 🙏🏻

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see! From my changes you'll see I've adopted TypeTables now, which are preferred where possible, as to avoid security scanners complaining about outdated vulnerable packaged jars. I've also fixed the test and recipe for the requestFactoryBuilder; nice to see that case covered too.

@timtebeek timtebeek merged commit 1670ac6 into openrewrite:main Apr 27, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.4 recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Recipes to upgrade to Spring Boot 3.4 Recipes to upgrade to Spring Framework 6.2
2 participants