-
Notifications
You must be signed in to change notification settings - Fork 101
Addresses part of Recipes to upgrade to Spring Boot 3.4 #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tory method in Spring Boot 3.4
…@ConfigurationProperties`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/security5/WebSecurityConfigurerAdapter.java
- lines 21-21
src/main/java/org/openrewrite/java/spring/boot3/AddValidToNestedConfigPropertiesRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/boot3/AddValidToNestedConfigPropertiesRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/boot3/AddValidToNestedConfigPropertiesRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/spring/boot3/AddValidToNestedConfigPropertiesRecipe.java
Outdated
Show resolved
Hide resolved
…idToNestedConfigPropertiesRecipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/spring/security5/WebSecurityConfigurerAdapter.java
- lines 21-21
Thanks a lot already @wapkch ! I didn't find time to get this reviewed and merged before yesterday's release, but know it's appreciated and we'll get this in before the next run. 🙏🏻 |
...t_3_4/java/org/openrewrite/java/spring/boot3/AddValidToNestedConfigPropertiesRecipeTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see! From my changes you'll see I've adopted TypeTables now, which are preferred where possible, as to avoid security scanners complaining about outdated vulnerable packaged jars. I've also fixed the test and recipe for the requestFactoryBuilder; nice to see that case covered too.
What's changed?
Checklist