Skip to content

Wrong units in Server Statistics uploaded/downloaded #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darkangeel-hd opened this issue Feb 28, 2025 · 3 comments
Open

Wrong units in Server Statistics uploaded/downloaded #259

Darkangeel-hd opened this issue Feb 28, 2025 · 3 comments
Labels
fix-committed Fix for the issue is in the main branch

Comments

@Darkangeel-hd
Copy link

Darkangeel-hd commented Feb 28, 2025

When showing server statistics I get the impression that if the numbers are too large, wrong units will be used.

Here are TrguiNG's:
Image

here are Transmission webui's:
Image

As you can see, global upload should be in PB, not TB
Maybe numbers this large were not contemplated for staters, as per:

const SISuffixes = ["B", "KB", "MB", "GB", "TB"];

It would be really nice if we could fix this.
But ofc is low priority as it doesnt impact functionality whatsoever.

Thank you so much, and if i can help in any way, pls tell me (I'm not familiar with the code of the app, neither with TS tho)

EDIT: after reading more of the code, i think just by adding the next unit to the SISuffixes array it should work, wouldn't it?

qu1ck added a commit that referenced this issue Mar 1, 2025
@qu1ck
Copy link
Member

qu1ck commented Mar 1, 2025

Done. Also kudos for seeding petabytes :D

@qu1ck qu1ck added the fix-committed Fix for the issue is in the main branch label Mar 1, 2025
@Darkangeel-hd
Copy link
Author

Thanks you!

When can I expect a ralease with this changes be made?

@qu1ck
Copy link
Member

qu1ck commented Mar 1, 2025

Probably in a few weeks, I still have some testing to do on linux and flatpak builds and want to squeeze in a feature or two.

But I started a build job and you will be able to grab a build of current master branch when it completes here https://github.com/openscopeproject/TrguiNG/actions/runs/13609495124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-committed Fix for the issue is in the main branch
Projects
None yet
Development

No branches or pull requests

2 participants