Skip to content

[4.19] Enable hermetic mode for additional images #6807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

[4.19] Enable hermetic mode for additional images #6807

merged 1 commit into from
May 26, 2025
+0 −9

Conversation

adobes1
Copy link
Contributor

@adobes1 adobes1 commented May 22, 2025

Enable hermetic mode for images which have only cachito and no enabled_repos

@adobes1
Copy link
Contributor Author

adobes1 commented May 22, 2025

Test build

@adobes1
Copy link
Contributor Author

adobes1 commented May 22, 2025

All images are passing except for monitoring-plugin and openshift-enterprise-console. I think both of these are hermetic-related issues.

@adobes1 adobes1 force-pushed the 4.19-enable-additional-hermetic branch from 817cd94 to ffae61b Compare May 22, 2025 11:07
@adobes1
Copy link
Contributor Author

adobes1 commented May 22, 2025

/cherrypick openshift-4.20

@openshift-cherrypick-robot
Copy link

@adobes1: once the present PR merges, I will cherry-pick it on top of openshift-4.20 in a new PR and assign it to you.

In response to this:

/cherrypick openshift-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adobes1 adobes1 changed the title Enable hermetic mode for additional images [4.19] Enable hermetic mode for additional images May 22, 2025
@joepvd
Copy link
Contributor

joepvd commented May 26, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit db41f12 into openshift-eng:openshift-4.19 May 26, 2025
2 checks passed
@openshift-cherrypick-robot
Copy link

@adobes1: new pull request created: #6822

In response to this:

/cherrypick openshift-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joepvd joepvd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adobes1 @openshift-cherrypick-robot @joepvd