Skip to content
This repository was archived by the owner on Mar 23, 2020. It is now read-only.

cnv: fixes issue #18 #33

Closed
wants to merge 1 commit into from
Closed

cnv: fixes issue #18 #33

wants to merge 1 commit into from

Conversation

karmab
Copy link
Contributor

@karmab karmab commented Aug 14, 2019

fixes #18

  • incorporate a script for bridge handling by detecting which nic to build the bridge on top of, and making the bridge name configurable
  • wait for this bridge to be properly ready on each master prior to deploying cnv
  • remove kubevirt web ui check as the relevant code lives in the openshift console

this is currently done without nmstate

@russellb
Copy link
Member

Is this for issue #18? If so, can you update the PR description and commit message to reference the issue?

@karmab karmab changed the title cnv: incorporate bridge handling cnv: fixes issue #18 Aug 15, 2019
@e-minguez
Copy link
Contributor

e-minguez commented Aug 21, 2019

I think it would be better to have a single post-install.sh script that:

@karmab
Copy link
Contributor Author

karmab commented Aug 26, 2019

I think it would be better to have a single post-install.sh script that:

agreed, so i left the bridge script as an optional step that one might want to launch when deploying CNV rather than during post install

@e-minguez
Copy link
Contributor

I believe this PR can be closed as the good one seems to be #42

@sreichar
Copy link
Collaborator

@karmab - any issue with closing this?

@e-minguez
Copy link
Contributor

ping @karmab

@sreichar
Copy link
Collaborator

sreichar commented Sep 9, 2019

ping @karmab - Should this be closed?

@karmab
Copy link
Contributor Author

karmab commented Sep 11, 2019

yes let s close it

@karmab karmab closed this Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Linux bridge on top of the default interface during the deployment
5 participants