Add Makefiles to CNV and OCS directories #57
Conversation
Signed-off-by: Johnny Bieren <[email protected]>
Signed-off-by: Johnny Bieren <[email protected]>
OpenShift/Makefile
Outdated
| @@ -1,14 +1,19 @@ | |||
| .PHONY: default all requirements configure | |||
| default: requirements configure | |||
There was a problem hiding this comment.
probably should have pre_install, cluster and post_install in
.PHONY
OpenShift/Makefile
Outdated
| @@ -1,14 +1,19 @@ | |||
| .PHONY: default all requirements configure | |||
| default: requirements configure | |||
|
|
|||
| all: default | |||
| all: cluster post_install | |||
There was a problem hiding this comment.
I am thinking the default should be just create, @e-minguez suggested leaving Post install as a manual step when I suggested his changes
@e-minguez - opinion of making post_install part of all - I am okay with that
There was a problem hiding this comment.
From what I gathered on the CNV-2.1 PR, the post_install steps will be necessary to deploy CNV-2.1, which is part of the appliance so I figured it should be part of all. However, if you guys think it is better to keep it out of all I can make that change np
OCS/Makefile
Outdated
| @@ -0,0 +1,5 @@ | |||
| .PHONY: all run | |||
| all: run | |||
There was a problem hiding this comment.
Is there a more descriptive target instead of "run"
Did you want to define a default?
CNV/Makefile
Outdated
| @@ -0,0 +1,8 @@ | |||
| .PHONY: all run upgrade | |||
| all: run | |||
There was a problem hiding this comment.
Is there a more descriptive target instead of "run"?
Did you want to install a default target?
|
Johnny can you also look at what I have pending as part of #50 |
|
Or I can keep my OCS and CNV Makefiles in this PR and drop the OpenShift and root level ones? |
…ets in OCS/CNV Makefiles Signed-off-by: Johnny Bieren <[email protected]>
|
I like the idea of the split, can you do OCS and CNV and I'll merge our Top level and OpenShift in PR #54 |
It is much easier from a CI perspective to have common make targets to call to deploy the various components of the appliance. Otherwise, changes to script names (such as the PR to add CNV-2.1) would break CI
This is following a similar mindset to #41
I force pushed my branch which made it so I couldn't reopen the old PR
Signed-off-by: Johnny Bieren [email protected]